Closed tomkennedy22 closed 7 months ago
Changed gallery range generation, so scalable features (eyeAngle, mouthSize, bodySize, etc) generate 11 options, and then sliderScale has 101 options
if (!rangeConfig.step || !rangeConfig.sliderStep) {
let range = rangeConfig.max - rangeConfig.min;
rangeConfig.step = roundTwoDecimals(range / 10);
rangeConfig.sliderStep = Math.max(roundTwoDecimals(range / 100), 0.01);
}
itemConfig.renderOptions.valuesToRender = generateRangeFromStep(rangeConfig.min, rangeConfig.max, rangeConfig.step)
For instance, Body Size has range 0.8 ➡️ 1.2. So the available options will be 0.8, 0.84, 0.88, 0.92, 0.96, 1.0, 1.04, 1.08, 1.12, 1.16, 1.20.
I think I'm done working on this... could keep going forever, but I think this is pretty good. @tomkennedy22 please take a look at it and let me know what you think - definitely possible I broke something! And let me know if there's anything else you'd like to do here, or if you think it's basically done too.
Then next step would be to ask a few people to test it and see what they say.
I think I'm done working on this... could keep going forever, but I think this is pretty good. @tomkennedy22 please take a look at it and let me know what you think - definitely possible I broke something! And let me know if there's anything else you'd like to do here, or if you think it's basically done too.
Then next step would be to ask a few people to test it and see what they say.
I think it looks great!
Actually the color gallery faces were broken! Fixed now, I'll put a beta version online soon
This is a fairly sizable diff that impacts a majority of the FacesJS site. The FacesJS core functionality - generate, display, etc, are somewhat changed, and I'll detail changes below, but not huge.
As of PR creation date [4/7/2024], this PR is NOT ready to land. Simply creating to spur conversation over features.
TODO:
Overall vision
FacesJS is great, and having a more interactive editor might bring more users to the site and engage more
Core Infra for Changes