Closed maxkarnold closed 2 years ago
"worst champion team" was probably a typo, please fix it in this PR :)
Want to do youngest championship teams in this PR too?
Another thing I noticed - this doesn't work for historical data in real player leagues, because it doesn't have avgAge computed. I should probably fix that myself, cause I can put it in the real player data generator which is not part of this repo.
I saw that all of your other frivolities, you just had "Oldest insert frivolity here" That makes sense, since you can just sort in reverse order and get the youngest champions. (Will definitely fix that typo as well)
I saw that all of your other frivolities, you just had "Oldest insert frivolity here" That makes sense, since you can just sort in reverse order and get the youngest champions
You can only do that if there are fewer than 100 seasons in the league, but frivolities are most interesting for very large leagues.
And for the other current "Oldest" frivolities a "Youngest" wouldn't be interesting, but here it is.
I saw that all of your other frivolities, you just had "Oldest insert frivolity here" That makes sense, since you can just sort in reverse order and get the youngest champions
You can only do that if there are fewer than 100 seasons in the league, but frivolities are most interesting for very large leagues.
And for the other current "Oldest" frivolities a "Youngest" wouldn't be interesting, but here it is.
Oh ok, haha. I guess I haven't played the game long enough to realize that.
I guess youngest former player sounds kinda stupid. And youngest to play in a game might also not be as interesting. I'll add the youngest championship 😄 .
Thanks! There were a couple other things I wanted to change a bit, but I just did them myself in 1cfa754f32676f85a6cd0d3c2d5a8c7bba163829 and c85ceccb5226236515256e220680260f9c4bf4aa.
I want to get avgAge working for historical seasons now, hopefully I'll do that soon before I release it otherwise I'm sure people will complain about it lol
avgAge
is undefined is 0, which I don't think should happen since it should filter out any seasons with noavgAge
.avgAge
is the main sortParam, but I includedwinp
in the unlikely case that there is the exact sameavgAge
value before rounding.