zengm-games / zengm

Basketball GM (and other ZenGM games) are single-player sports management simulation games, made entirely in client-side JavaScript.
https://zengm.com
Other
349 stars 127 forks source link

Add Custom Team #429

Closed mamamia5x closed 1 year ago

mamamia5x commented 1 year ago

Hello DumbMatter, I felt a little inspired by the Albuquerque Thunderbirds and decided to make my own team.

Hailing from the 49th state, I'd like to announce the Anchorage Glaciers.

Main Logo

Main Logo

Secondary Logo

Secondary Logo Note: I suck at graphic design I made it a PNG and then had to use a different software to convert it to an SVG, thus the look.

Screenshots

Team Schedule

Schedule

Roster

Roster

Player

Player

Add Team

Add Team

dumbmatter commented 1 year ago

Thanks! I like the logo and the colors. And it is natural that Alaska should have a team, since Hawaii got one.

Where did you get the design from? Like did you draw it yourself, or find it somewhere online? If online, where? Cause in that case I need to make sure the license allows me to use it.

Also about the PNG/SVG issue... what you have now aren't really SVG files. Well technically they are, but they contain an embedded PNG image. That's why they still look a little blurry, and also why the file size is larger than the other logos.

It is possible there is some tool that would convert this to a "real" SVG (containing the actual lines/shapes in the image, rather than just encoded PNG data), since it does look like it has a lot of sharp edges and smooth lines. But I'm not an expert on that kind of stuff.

You also might want to reach out to the guy who did the Albuquerque and Oakland logos on Discord, since he had the same issue originally. His Discord username is BigBlue642#4640

mamamia5x commented 1 year ago

I used a Fiverr logo maker, then I opened my photo editor to try and remake it. In a nutshell, I got the original design from Fiverr, then I remade it myself and made some changes. Then I had it made into an SVG. I'm not sure where this falls onto in a licensing standpoint.

I'll do some research and try to figure it out.

mamamia5x commented 1 year ago

Alright, I think I found someone who can help me redo the logo to make it legally safe, give me a day or 2.

mamamia5x commented 1 year ago

Alright logos have been updated for SVG format

Thanks to Saraorigin for helping me out New Main: Main

New Secondary Second

I got permission to use it as long as they are "for charitable and non-commercial activities".

dumbmatter commented 1 year ago

General git tip - don't work on master when you're preparing a PR on someone else's repo. Because then your master and their master will grow out of sync. Instead, work on a separate branch.

Not a big deal this time, but in the future you should do it.

dumbmatter commented 1 year ago

I'm going to merge and make a couple little tweaks :)

dumbmatter commented 1 year ago

https://github.com/zengm-games/zengm/commit/2c0c8d8d69382577c9c43d0fb1a344628f2030e3

Thanks again for your help! It'll be in the next release.

mamamia5x commented 1 year ago

Sweet, thanks!

dumbmatter commented 1 year ago

Do you have a PayPal account? Email me if you want a little thank you!