search

zengm-games / zengm

Basketball GM (and other ZenGM games) are single-player sports management simulation games, made entirely in client-side JavaScript.
https://zengm.com
Other
349 stars 127 forks source link

added the player trading card #447

Open ItamarTati opened 1 year ago

ItamarTati commented 1 year ago

I need some help with when it should and shouldn't render, how do I determine who is a legend.

And Also where should the card be

dumbmatter commented 1 year ago

Thanks! Looks like a good start, I will probably merge it and mess around with it.

Sorry for not mentioning before, but can you make sure you're okay with the license and sign the CLA? https://github.com/zengm-games/zengm/tree/master#license-and-contributor-license-agreement

ItamarTati commented 1 year ago

Thanks! Looks like a good start, I will probably merge it and mess around with it.

Sorry for not mentioning before, but can you make sure you're okay with the license and sign the CLA? https://github.com/zengm-games/zengm/tree/master#license-and-contributor-license-agreement

I sent an email agreeing to the terms and explaining my current situation.

If you need any help merging it in feel free to message me :)

ItamarTati commented 9 months ago

@dumbmatter do you still want to merge this in, do you need any help?