search

zengm-games / zengm

Basketball GM (and other ZenGM games) are single-player sports management simulation games, made entirely in client-side JavaScript.
https://zengm.com
Other
349 stars 127 forks source link

Issue #431 Add force retire season #455

Closed snzow closed 10 months ago

snzow commented 10 months ago

431

snzow commented 10 months ago

Ok it has been updated to use draft year and give a redshirt based on the number of unique seasons. I tried to come up with a clever way to count unique seasons to avoid iterating through them all but wasn't able to find one.

snzow commented 10 months ago

ok should hopefully meet all requirements now

dumbmatter commented 10 months ago

I realized that in my code I forgot to do what I mentioned previously about startingSeason (don't count seasons before startingSeason as potential redshirt seasons, otherwise everyone would get a redshirt season in a new league). So I added that and renamed the variable to forceRetireSeasons because I like that name better :)

I will merge it soon, and then it'll be in the next update - not sure exactly when, but pretty soon.

If you'd like to test the final version, please do, and please let me know if you notice any problems!

And thank you! If you're interested in doing other stuff, feel free to talk to me about ideas.

astrxcy commented 10 months ago

wowee when you think updates coming out