zengm-games / zengm

Basketball GM (and other ZenGM games) are single-player sports management simulation games, made entirely in client-side JavaScript.
https://zengm.com
Other
349 stars 127 forks source link

Basketball GM - Exhibition Games, Play By Play mini-icons are wrong sometimes #460

Closed Vicescq closed 6 months ago

Vicescq commented 6 months ago

image

To the right of the picture, you can see that the icons do not correspond to the teams that are playing, I also tried to inspect element and it clearly showed the wrong svg file.

How to reproduce: It seems kinda random, it only occurs with randomly generated leagues, it never happens when you select teams from the "Real Historical Teams" set (AFAIK). Try making a new league with random players, and match it up with another team. Theres a possibility of it having the wrong mini-icon.

dumbmatter commented 6 months ago

Thanks, there were two bugs!

Small logos were not being included in the team info when doing an exhibition game (before the play-by-play update it didn't matter, because they were not used in exhibition games). So then it was falling back to using the large logos... except in the case where you had an existing league loaded (like you had it open in another tab, or had opened a league before going to the exhibition game), then it was pulling small logos from that league. Both bugs will be fixed in the next update.