Extra games being played (83+ game seasons, 4 wins not finishing a playoff series)

[dumbmatter]

See this error and my comment there: http://www.reddit.com/r/BasketballGM/comments/326ddi/83_game_season_finally_caught_error_in_console/

Related: are errors inside promises being sent to Bugsnag?

• https://www.google.com/search?client=ubuntu&channel=fs&q=bugsnag+promises&ie=utf-8&oe=utf-8
• https://github.com/petkaantonov/bluebird/issues/452#issuecomment-70410373

[dumbmatter]

Fixed the Bugsnag/Bluebird thing with https://github.com/dumbmatter/basketball-gm/commit/7da2bca9ab7e8489045d23d6a032dc9459947809 hopefully.

[dumbmatter]

http://www.reddit.com/r/BasketballGM/comments/326ddi/83_game_season_finally_caught_error_in_console/cq8vr5i is pretty strange. Something is not right.

Could be a weird IDB bug like https://github.com/dumbmatter/basketball-gm/commit/5e1d10a487442a79f255b8f4f6713a2a0bc2d59e that could maybe be fixed by refactoring game saving code so tx.complete is not called early. But that bug never resulted in an actual error message or aborted transaction, just an inconsistent result in the database.

[dumbmatter]

Various playoffs glitches: http://i.imgur.com/8dVrmf8.jpg

[dumbmatter]

Latest thinking: http://www.reddit.com/r/BasketballGM/comments/326ddi/83_game_season_finally_caught_error_in_console/cqdmfr4

[dumbmatter]

A couple commits that might have helped things, either by making the transaction less likely to auto-commit early or by making it faster: https://github.com/dumbmatter/basketball-gm/commit/72a8a8121d79a1939b1e7358ede0a9fac7de79ab https://github.com/dumbmatter/basketball-gm/commit/4f810e97bc0918e34dcd6818d7aa42913b4535fe

Waiting for feedback: http://www.reddit.com/r/BasketballGM/comments/3313c1/is_anyone_still_seeing_the_extra_games_bug_on/

[dumbmatter]

I don't think I ever definitively fixed this, but I haven't heard of it happening lately.