zengxs / gitlab-arm64

GitLab docker image (CE & EE) for arm64
Apache License 2.0
149 stars 29 forks source link

wget missing url #102

Open F041 opened 5 months ago

F041 commented 5 months ago

At the end of the installation, I presume, I get the following image

I selected 16.7.3-ce.0 as in the example

zengxs commented 4 months ago

In recent versions of the Dockerfile, the DOWNLOAD_URL variable has been changed to DOWNLOAD_URL_amd64 and DOWNLOAD_URL_arm64. If you need to build an older version, you need to switch to the corresponding version's commit.

For version 16.7.3, I think you need to use this commit: https://github.com/zengxs/gitlab-arm64/tree/538df3e194b2c2c6b3d0b1194411f0d87c7773c8

I hope this resolves your issue. If you have any further questions, feel free to ask.

F041 commented 4 months ago

Sorry for writing something that might belong to mistakes of newbies.

Process:

docker pull zengxs/gitlab:16.0.4-ce.0

git clone https://github.com/zengxs/gitlab-docker.git

cd gitlab-arm64
# Build GitLab CE image
docker build . \
   -t gitlab-ce:16.0.4-ce.0 \
   --build-arg RELEASE_PACKAGE=gitlab-ce \
   --build-arg RELEASE_VERSION=16.0.4-ce.0
# Build GitLab EE image
docker build . \
   -t gitlab-ee:16.0.4-ce.0 \
   --build-arg RELEASE_PACKAGE=gitlab-ee \
   --build-arg RELEASE_VERSION=16.0.4-ce.0

Same error.

zengxs commented 4 months ago

I apologize for the delayed response.

I've reviewed your steps and noticed that there is a critical step missing. After you git clone the repository, you need to switch to the specific commit of the version you're referring to.

Here are the corrected steps:

  1. Clone the repository:

    git clone https://github.com/zengxs/gitlab-arm64.git
  2. Navigate to the repository directory:

    cd gitlab-arm64/
  3. Find the specific commit hash. You can do this by:

    • Visiting the repository on GitHub.
    • Navigating to the "Commits" section.
    • Looking through the commit messages to find the commit corresponding to the GitLab version you want to build.
  4. Checkout the specific commit:

    # check out to the commit hash, eg. the commit hash of 16.11.1 is 47838c68db7d51eaae5c8588072689571ff3e0cd
    git checkout 47838c68db7d51eaae5c8588072689571ff3e0cd

Please try this and let me know if you encounter any further issues.

F041 commented 4 months ago

after the checkout I did

docker build . \
   -t gitlab-ce:16.11.1-ce.0 \
   --build-arg RELEASE_PACKAGE=gitlab-ce \
   --build-arg RELEASE_VERSION=16.11.1-ce.0
# Build GitLab EE image
docker build . \
   -t gitlab-ee:16.11.1-ce.0 \
   --build-arg RELEASE_PACKAGE=gitlab-ee \
   --build-arg RELEASE_VERSION=16.11.1-ce.0

but I get the same error. Wrong assumption of the final step?

zengxs commented 4 months ago

I apologize for the oversight. You are right, I have rechecked the build commands, and starting from version 16.11.1, an additional TARGETARCH build-arg is required. [ref this]

Please update your build command to include this argument, like so:

docker build . \
   -t gitlab-ce:16.11.1-ce.0 \
   --build-arg RELEASE_PACKAGE=gitlab-ce \
   --build-arg RELEASE_VERSION=16.11.1-ce.0 \
   --build-arg TARGETARCH=arm64
# Build GitLab EE image
docker build . \
   -t gitlab-ee:16.11.1-ce.0 \
   --build-arg RELEASE_PACKAGE=gitlab-ee \
   --build-arg RELEASE_VERSION=16.11.1-ce.0 \
   --build-arg TARGETARCH=arm64

For versions prior to 16.11.1, this parameter is not required.

F041 commented 4 months ago

image

Looking at chatGPT and then the 16.11.1 repo, I presume the problem comes from the dockerfile

zengxs commented 4 months ago

I apologize for the ongoing issues you're experiencing. I've been quite busy, which has slowed down my response time. However, I plan to look into this further later this week. I will try to reproduce the problem in my testing environment and work on finding a solution.

Thank you for your patience.

F041 commented 4 months ago

No problem, I appreciate your care