zengzihui / pe

0 stars 0 forks source link

Inaccurate error message for invalid date #2

Open zengzihui opened 4 months ago

zengzihui commented 4 months ago

image.png

When an invalid date with a valid date format is entered, such as 2001-02-30, the error message stated that it is an invalid date format. However, this is an valid date format with invalid input as it follows the input format, is just the value is invalid. Hence, I feel perhaps when user enter an valid date format but an invalid date such as 30 February, the program could display a more specific error message to remind the user of their input mistakes.

nus-pe-bot commented 4 months ago

Team's Response

Bug has already been reported.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Wrong output message when trying to add invalid birthday

Screenshot 2024-04-19 at 4.22.15 PM.png

Explanation: User may accidentally input an invalid birthday. The output error message is not clear enough for the user to realise that the birthday is invalid.


[original: nus-cs2103-AY2324S2/pe-interim#4255] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Accepted as a bug but of VeryLow severity as the incorrect error message shown is a cosmetic issue.

In addition, the requirement that a 'valid date' must be entered, is stated in the user guide, under the 'Parameter Constraints' section.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/zengzihui/pe/main/files/b732c468-6a17-4f4b-b43d-46509794ac54.png) According to the guideline provided in the website, this is a low severity bug, incorrect error message is not a cosmetic issue.