zengzihui / pe

0 stars 0 forks source link

Possibility of combining more than one enhancement in an enhancement listed in developer guide #8

Open zengzihui opened 4 months ago

zengzihui commented 4 months ago

image.png image.png

These two possible future enhancements stated in the developer guide are quite generic, it never specify the input fields which that the data validation need to be improve or error messages for which command should be more specific. Hence, I feel these two enhancements might be involving more than one enhancement for each of them.

soc-pe-bot commented 4 months ago

Team's Response

Rejected as it was always clear as a group that the planned enhancements were meant to be carried out across all the input fields, as it would be very inconsistent in the product if the enhancements were to only be done on a small subset of features. We see no benefit in breaking the planned enhancements down into subsets.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

https://nus-cs2103-ay2324s2.github.io/website/admin/tp-deliverables.html#deliverable-developer-guide-dg

According to the guideline provided in the website above, it stated that each enhancement should be specific, describing the feature flaw it addresses and how exactly the feature will be changed.

The two enhancements mentioned above, which I have screenshotted, are not specific and are too general. They do not describe the specific feature flaws that your team is planning to address.

image.png Besides that, according to the guideline provided here, if any of the enhancements in the list combines more than one enhancement, it can be reported as a documentation bug.