search

zenhack / iron-blogger2

GNU General Public License v3.0
3 stars 3 forks source link

shorter per page count in pagination #45

Closed jywarren closed 9 years ago

jywarren commented 9 years ago

It's a pretty long scroll on a phone... Not sure what it's at currently but maybe 10-20 posts would be good?

zenhack commented 9 years ago

Quoting Jeffrey Warren (2015-08-07 14:20:17)

It's a pretty long scroll on a phone... Not sure what it's at currently but maybe 10-20 posts would be good?

Right now it's 50. My original reasoning was that with ~30 people this would let you see at a minimum the current round and change, most of the time.

I can think of a handful of ways to approach this:

  1. Do as you suggest and reduce it
  2. Make it configurable (and reduce it on the instance we're using)
  3. Make it a function of the number of bloggers
  4. Make it a function of time.

Doing (4) would mean that pages might be different sizes, though from week to week they should be similarly sized.

My gut is that (1) or (2) is probably the right answer. What do other people think?

// cc @hlieberman, @shaunagm

shaunagm commented 9 years ago

This is a question near and dear to my heart! If you look at the original repo (or rather, Paultag's fork of the original repo) you can see my very first free software code contribution:

https://github.com/paultag/iron-blogger/commit/abe5a57a68ccfd4426f1a73bf6d365c7f19e9173

As the diff makes clear, I favor a greater # of posts, but a configurable version would be fine by me.

jywarren commented 9 years ago

:-)

This is mainly an issue on mobile. I've never really thought about paginating by anything by count, so that's a new one for me... no worries, this isn't a big deal, it's just many seconds of scrolling to see anything near the bottom of the page, so I thought I'd ask. Doesn't really seem that important, and we could in theory display only titles on mobile devices, with a click to display the whole post or something.

On Sun, Aug 9, 2015 at 4:59 PM, shaunagm notifications@github.com wrote:

This is a question near and dear to my heart! If you look at the original repo (or rather, Paultag's fork of the original repo) you can see my very first free software code contribution:

paultag/iron-blogger@abe5a57 https://github.com/paultag/iron-blogger/commit/abe5a57a68ccfd4426f1a73bf6d365c7f19e9173

As the diff makes clear, I favor a greater # of posts, but a configurable version would be fine by me.

— Reply to this email directly or view it on GitHub https://github.com/zenhack/iron-blogger2/issues/45#issuecomment-129239893 .

zenhack commented 9 years ago

I think at a minimum having a server side config option would be a good thing, but that doesn't immediately translate to something visitors of the site can tweak. It would at least let an administrator tune the count if the default doesn't meet their group's needs (assuming anyone besides us ever uses it, though it would also be nice to be able to tweak for a large or smaller group).

I worry about cluttering up the interface by adding too many knobs to the page. @shaunagm, can you explain why you prefer larger pages?

It would be pretty easy to make the size adjustable by the user; you can already do it actually, though a button would probably be nice:

http://ironblogger-idenhardt.rhcloud.com/posts?page_size=10

(@jywarren, feel free to bookmark that while we continue to discuss)

shaunagm commented 9 years ago

The old site didn't have any pagination, so once a post scrolled off the original 15 items, it was lost forever. Upping the # of items was quicker than configuring the planet to have pagination, and now I'm rather used to it. With pagination, it's pretty much a non-issue. If you can set 10 to the default, I'm happy to make ?page_size=50 my bookmark instead.

jywarren commented 9 years ago

I am bookmarked, so no urgency here.

On Thu, Aug 13, 2015 at 9:34 AM, shaunagm notifications@github.com wrote:

The old site didn't have any pagination, so once a post scrolled off the original 15 items, it was lost forever. Upping the # of items was quicker than configuring the planet to have pagination, and now I'm rather used to it. With pagination, it's pretty much a non-issue. If you can set 10 to the default, I'm happy to make ?page_size=50 my bookmark instead.

— Reply to this email directly or view it on GitHub https://github.com/zenhack/iron-blogger2/issues/45#issuecomment-130673873 .

zenhack commented 9 years ago

Okay. I think I'll add the server side option and shorten the default. One I've done so I'll close this.