search

zenhack / powerbox-http-proxy

Apache License 2.0
4 stars 3 forks source link

Add Dockerfile #10

Closed garrison closed 3 years ago

garrison commented 3 years ago

This adds a Dockerfile that builds on the sandstorm-http-bridge base image and incorporates the build results of this repository (/powerbox-http-proxy and /build/index.js).

Right now, the version of each base image is unspecified, so each image defaults to latest. I could set this explicitly if you would prefer the builds be fully reproducible.

On IRC, I had suggested that I might make a Dockerfile for this package and add it to https://github.com/zenhack/docker-spk/tree/master/base-images; however, doing so would have meant fetching a tarball of this repository, and it seemed easier just to COPY . . from here instead.

zenhack commented 3 years ago

I could set this explicitly if you would prefer the builds be fully reproducible.

I think I would. Otherwise LGTM.

garrison commented 3 years ago

Updated accordingly.

zenhack commented 3 years ago

Merged, and pushed to dockerhub as zenhack/powerbox-http-proxy