search

zenhack / powerbox-http-proxy

Apache License 2.0
4 stars 3 forks source link

Drop npm & typescript #11

Closed zenhack closed 1 year ago

zenhack commented 1 year ago

IMO there's not really enough javascript here to justify pulling in NPM just for typescript; I am willing to do without a typechecker if we can simplify the build.

This patch converts the typescript javascript, and gets rid of the NPM build step.

I'm going to sanity check this works with ttrss before merging.

Note that users will have to update the path from build/index.js to powerbox-http-proxy.js (cc @ocdtrekkie, @orblivion)

ocdtrekkie commented 1 year ago

Hmmm... would it be smart or reasonable to do something like typechecking when developing this thing, but publishing the JS so people don't need to build it to deploy it?

Perhaps right now it's simple enough it shouldn't matter.

zenhack commented 1 year ago

Quoting Jacob Weisz (2023-01-27 19:29:36)

Perhaps right now it's simple enough it shouldn't matter.

This was my thinking; it also doesn't seem likely to grow dramatically.

I don't think doing an npm build is a horrible thing, but it seemed excessive given the size of this.

zenhack commented 1 year ago

Confirmed working; merging.

orblivion commented 1 year ago

I was kind of thinking the same thing, thanks for simplifying it.

On Fri, Jan 27, 2023 at 7:54 PM Ian Denhardt @.***> wrote:

Merged #11 https://github.com/zenhack/powerbox-http-proxy/pull/11 into master.

— Reply to this email directly, view it on GitHub https://github.com/zenhack/powerbox-http-proxy/pull/11#event-8378396953, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAKH6C775MT527VL6UXI5DWURU3XANCNFSM6AAAAAAUJKDYIA . You are receiving this because you were mentioned.Message ID: @.***>