Switch main() test to subprocess.call

zenhack / simp_le

Simple Let's Encrypt client

GNU General Public License v3.0

224 stars 38 forks source link

Switch main() test to subprocess.call #108

Closed buchdag closed 6 years ago

buchdag commented 6 years ago

Similar to what was done with IntegrationTests in #82

buchdag commented 6 years ago

Don't really know if that's desirable or not, the test take longer this way (~7 seconds instead of almost instantaneous).

buchdag commented 6 years ago

Nope, no logging issue with this one because it was completely silent (as part of simp_le --test). That explains the stdio silencing too.

To be honest I worked on this branch a while ago, I'm pretty sure it was related to the wall I hit with the self tests when splitting the main simp_le.py in modules (I'm still stuck on this one) and I'm not sure at all it has any merit on its own.

zenhack commented 6 years ago

Ok, I'm going to close then.