search

zenhack / simp_le

Simple Let's Encrypt client
GNU General Public License v3.0
224 stars 38 forks source link

Upgrade ACME to 1.2 #136

Closed buchdag closed 4 years ago

buchdag commented 4 years ago

The usual chore.

zenhack commented 4 years ago

Hm, do we actually need to bump the version here? we haven't made any changes and the existing constraint will accept newer versions.

(we should probably add a <2.0 constraint; I thought I'd done that...)

buchdag commented 4 years ago

I don't really get why we switched from having a new tagged release when we bumped ACME minor version number to tagged release on ACME major version number in the first place.

TBH that's a bit annoying as it forces me to do a manual rebuild and push of jrcs/letsencrypt-nginx-proxy-companion images if I want to update the ACME minor version used by the image's simp_le, without any corresponding commit to track the change.

zenhack commented 4 years ago

The switch is because, per semver, 1.x marks the start of a stable API (I'm assuming acme is intends to follow semver, as it's recommended for python packages generally. but maybe we should check).

Previously we had to track individual versions because there was no compatibility guarantee from one to the next. Semver requires that a breaking change wrt the 1.x series should see a major version bump, so we should have to tweak the bounds much less often now.

Re: the docker image, perhaps you could commit the output of pip freeze, rather than just recording the simp_le version in a script? This would have the advantage of making things more reproducible generally.

buchdag commented 4 years ago

Okay, the semantic versioning arguments make sense.

Using the output of pip freeze is a possibility but it will be a bit less convenient than just bumping a version number. How would you do this if you had to ? Using a virtualenv on a local machine ?

zenhack commented 4 years ago

Yeah, I'd probably use a local venv to generate it.

buchdag commented 4 years ago

So, acme>=1.3 <2.0 and be done with it ?

(yeah by the way 1.3 was released two days ago)

zenhack commented 4 years ago

SGTM.

Quoting Nicolas Duchon (2020-03-05 08:32:05)

So, acme>=1.3 <2.0 and be done with it ?

-- You are receiving this because you commented. Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe.

Verweise

  1. https://github.com/zenhack/simp_le/pull/136?email_source=notifications&email_token=AAGXYPUGJ3DUPE3UTEG6N33RF6SVLA5CNFSM4K7QYAV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN5ICVA#issuecomment-595231060
  2. https://github.com/notifications/unsubscribe-auth/AAGXYPXG5RNY2CB2W2PMUZLRF6SVLANCNFSM4K7QYAVQ