search

zenhack / simp_le

Simple Let's Encrypt client
GNU General Public License v3.0
224 stars 38 forks source link

Change generated CSR version to 0 #155

Closed aaomidi closed 2 years ago

aaomidi commented 2 years ago

CSRs are PKCS#10 documents, and the standard does not define versions above 0.

Reference: https://github.com/certbot/certbot/pull/9334

zenhack commented 2 years ago

Have you tested this to verify it actually works against boulder? (per the now-removed comment, I assume this fixed some problem at some point).

(Relatedly, we should get the integration tests running in CI again; we never moved to something else after travis shut down)

I think I will want to try dogfooding this before merging. Fortunately it's getting to be time to renew my own certs, so that should happen soonish.

aaomidi commented 2 years ago

Yep it works there. Also certbot also has changed this too.

zenhack commented 2 years ago

Seems to work for me. Merging. Thanks.