search

zenhack / simp_le

Simple Let's Encrypt client
GNU General Public License v3.0
224 stars 38 forks source link

New account key is not preserved on failure #16

Closed zenhack closed 7 years ago

zenhack commented 7 years ago

Issue by Lekensteyn Tuesday Jan 05, 2016 at 20:55 GMT _Originally opened as https://github.com/kuba/simp_le/issues/58_

When an account key is created, but the authorization failed (because the HTTP server is not reachable for example), the account key key is not stored. It should probably persist this key even if it failed to generate a certificate.

Edit: what about allowing simp_le to generate just the account key and nothing else? I.e. allow simp_le.py -f account_key.json to generate the account key. Then a wrapper script can ensure that this file is available and store it appropriately.

buchdag commented 7 years ago

Edit: what about allowing simp_le to generate just the account key and nothing else? I.e. allow simp_le.py -f account_key.json to generate the account key.

Got that working on a local branch.

Storing the account key on authorization failure does not seem too hard either.

buchdag commented 7 years ago

Okay, I've got both working.

Storing the account key on authorization failure is a no brainer, but I'm not really sure about the usefulness of being able to generate just the account key.

zenhack commented 7 years ago

73 is merged, so I'm going to close.

buchdag commented 7 years ago

@zenhack thanks !

By the way, what is your take on enabling the separate generation of an account_key with simp_le? Useful, feature creep ?

zenhack commented 7 years ago

It strikes me as feature creep.