search

zenhack / simp_le

Simple Let's Encrypt client
GNU General Public License v3.0
224 stars 38 forks source link

Support for acme 0.15 #56

Closed klemens closed 7 years ago

klemens commented 7 years ago

Acme 0.15.0 throws an errors.ConflictError with the uri of the already registered account instead of a messages.Error containing the response json. This was introduced in: certbot/certbot@10bac10.

I am not sure if you want to raise the required acme version yet, but as I am using arch linux, which already provides acme 0.15, I thought this might be useful. I am also not sure if these are all the required changes for the new acme version, but at least all my cert-updates went through successfully.

zenhack commented 7 years ago

Mostly looks ok, but I'd like to keep an upper bound <0.16 in place to guard against breakage from future versions. I'll also want to give it a closer look later when I have time to sit down and do so.

Thanks for the patch!

klemens commented 7 years ago

Sounds reasonable, I added back the upper bound.

zenhack commented 7 years ago

Cool, merging.