search

zenhob / hcl

Command-line tool for manipulating Harvest timesheets
http://zenhob.github.io/hcl
MIT License
223 stars 45 forks source link

install byebug on ruby 2.1, 2.2 #62

Closed asymmetric closed 9 years ago

asymmetric commented 9 years ago

Adds ruby-2.{1,2} to the platform array in the Gemfile.

This approach to supporting multiple platforms is not scalable though. What about using different Gemfiles?

zenhob commented 9 years ago

Good catch. I'm open to improving on this approach. Since the debugger is just used for development, I'm mostly concerned that it covers the environments that we use, and not necessarily every single supported ruby env.

Thanks for the fix! I'll merge this soon.

asymmetric commented 9 years ago

Weird, apparently ruby_22 is not a valid platform, although it's listed here.

This should anyway be mri_20, mri_21, mri_22, as ruby means both MRI and Rubinius, according to that man page - I'll fix it.

asymmetric commented 9 years ago

After making the change, mri_22 is still unrecognized on bundler 1.7.6, used by ruby-2.0.0 - could the bundler version be the issue?

zenhob commented 9 years ago

That's weird. I wonder if mri without a version is meant to represent the latest (e.g. 2.2)?

asymmetric commented 9 years ago

I think mri without a version probably means any MRI/Rubinius, so that wouldn't work for us I'm afraid.