search

zenkay / simple-spreadsheet

Simple spreadsheet is a Ruby Gem reader for common spreadsheet formats: Excel (.xls, .xlsx), Open-office (.ods) and CSV (standard, excel, tab separated)
https://rubygems.org/gems/simple-spreadsheet
MIT License
98 stars 32 forks source link

zip is not a gem requirement in gemspec #8

Closed cannapages closed 9 years ago

cannapages commented 9 years ago

If you use without bundling zip gem with it you will get `require': cannot load such file -- zip/zipfilesystem (LoadError)

Guoxweii commented 9 years ago

L have one too

Tuckie commented 9 years ago

+1

leifg commented 9 years ago

This problem stems from a dependency problem in roo (see https://github.com/roo-rb/roo/pull/65)

There are several ways to fix this:

  1. depend on earlier version of rubyzip
  2. depend on higher version of roo

I prefer option 2 as it is the better longterm solution.

I will provide a PR

zenkay commented 9 years ago

Thank you very much guys, I noticed the problem several days ago but I hadn't time to fix it Now, thanks to @leifg, I pushed the update and a new version (0.3.1) of the gem. Please let me know if you still have problems.

leifg commented 9 years ago

Yeah, you were too fast with merging.

This version will not work with csvt and csvx.

opened a second pull request though to address this issue #10