zenkkor / ngx-credit-cards

A Credit Card Directives and Form Validators package for Angular X (2+)
MIT License
30 stars 36 forks source link

Issue with build in angular 4 #2

Closed maitham closed 7 years ago

maitham commented 7 years ago

Hey there, DOes this support angular 4, as I keep getting ngc check failed:

https://stackoverflow.com/questions/43945912/angular-module-failing-ngc-check-no-idea-why

ziemerz commented 7 years ago

I'm having te exact same error when AOT transpiling Angular 4.x

nwrman commented 7 years ago

Same here, I think it's just a minor detail, but I just can't grasp my head around it.

lucaswxp commented 7 years ago

same here

maitham commented 7 years ago

I ended up just pulling the methods I needed from their library into my own TS files rather than importing the library

slavafomin commented 7 years ago

Is this module maintained?

nwrman commented 7 years ago

I did what @maitham1 suggested and it's working flawlessly :)

zenkkor commented 7 years ago

Merged a PR from a user so should be good now

Keko94 commented 6 years ago

I reopen this ticket because the bug doesn't seem to be fixed: When I run in dev mode, it works, but in prod mode, it doesn't work anymore.

[23:28:39] build prod started ... [23:28:39] clean started ... [23:28:39] clean finished in 2 ms [23:28:39] copy started ... [23:28:39] deeplinks started ... [23:28:39] deeplinks finished in 123 ms [23:28:39] ngc started ... [23:28:42] typescript error Unexpected value 'NgXCreditCardsModule in /Users/keko/Documents/pharma/node_modules/ngx-credit-cards/index.js' imported by the module 'AppModule in /Users/keko/Documents/pharma/src/app/app.module.ts'. Please add a @NgModule annotation.

I use Ionic with Angular 5

jayeshkorat18 commented 6 years ago

+1 I use Ionic 3 with Angular 5 same issue

guilherme22 commented 6 years ago

Using angular 5.3 and the same error here.

dentkachuk commented 6 years ago

angular 6 +1

botoxparty commented 5 years ago

Angular 6 & 7 +1

timmyrosen commented 5 years ago

Angular 7 +1

keriroso commented 4 years ago

I create a modules folder. Captura de Pantalla 2020-06-21 a la(s) 01 26 03

add app.module.ts and in the 'imports' import { NgXCreditCardsModule } from '../module/ngx-credit-cards/ngxcreditcard.module';

also remove 'fns' in the directives Payment.formatCardExpiry(element); Payment.restrictNumeric(element);