Closed maxmynter closed 5 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository.To trigger a single review, invoke the
@coderabbitai review
command.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@maxmynter This docs change is def a no-brainer. Icing on the cake would be to add some validation when we check the spec for exactly this case. The parse_and_extract_component_variables
function might be a place for that to go, but in any case that might be a bigger effort to add a bit more pre-flight validation. I'll create a ticket for it in our internal tracker but feel free to go down that road if inclined! I'll get this merged in. Thank you for your contribution!
Describe changes
Convert underscores in AWS Quickstart guide to hyphens to make it compatible with AWS resource naming requirements which do not allow underscores.
Tested on macOS 14.1.2 with AWS.
Closes https://github.com/zenml-io/mlstacks/issues/127
Pre-requisites
Please ensure you have done the following:
I have added tests to cover my changes.develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes
Documentation changes.