search

zenml-io / mlstacks

A series of Terraform based recipes to provision popular MLOps stacks on the cloud.
https://mlstacks.zenml.io/
Apache License 2.0
245 stars 32 forks source link

Update outputs.tf to make `project_id` match GCP usage #98

Closed strickvl closed 9 months ago

strickvl commented 9 months ago

Tiny fix to make the outputs for project_id match the value / usage in GCP.

@wjayesh is there any reason I should NOT make this change? Also potentially a breaking change if someone's depending on the outputs to be fixed?

wjayesh commented 9 months ago

I don't remember any prominent consumers of the project_id output save for the stack component configuration. In case we need to ensure backwards compatibility, we can keep the existing output and add the new one too? But I don't think it should be a huge problem for the end user.

strickvl commented 9 months ago

Actually probably not worth it. I think it's clear in any case without this change.