Closed Christopher-R-Perkins closed 4 months ago
This update improves the project's robustness and maintainability. It enhances the error handling in the restartServer
function within server.ts
, ensuring that any issues encountered while stopping the server are logged but do not prevent the server from restarting. Additionally, it excludes dag-packed.js.map
from version control by updating the .gitignore
file.
File | Change Summary |
---|---|
.gitignore |
Added dag-packed.js.map to exclude this file from version control. |
src/common/server.ts |
Enhanced restartServer function with error handling for stopping the language server, logging errors if they occur. |
sequenceDiagram
participant User
participant Server
participant Logger
User->>Server: Request to restart server
Server->>Server: Stop server
alt Stop succeeds
Server->>Server: Start server
else Stop fails
Server->>Logger: Log error
Server->>Server: Start server
end
In the code's soft hum, a change refined,
Errors now logged, no restart left behind.
With maps ignored, the repo stays neat,
Robust and tidy, a coder's feat. 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This pull request contains a fix for restarting the Language Server when the Language Server was never able to start.
changes:
dag-packed.js.map
to.gitignore
to remove build artifact from repositoryThis Language Server restart only happens when the python interpreter is changed, thus this fixes issues when an unsupported python interpreter is chosen. Before you would have to change the interpreter and then disable->restart->enable the extension for it to start the client again as the stop error was not handled. Now, the extension will try to restart the server even if the server was not previously started.
Summary by CodeRabbit
Chores
.gitignore
to excludedag-packed.js.map
.Bug Fixes