Closed stefannica closed 3 weeks ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
Package | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|
pypi/google-cloud-artifact-registry@1.11.3 | environment, filesystem, network Transitive: eval, shell, unsafe | +17 |
5.69 MB | gcloudpypi, google_opensource |
Describe changes
Adds support for Google Artifact Registry as a drop-in replacement for the deprecated Google Container Registry in the GCP Service Connector.
The
docker-registry
resource type has been converted from a single-instance resource type into a multi-instance resource type. A GCP Service Connector can be configured to give access to not one but many GAR (Google Artifact Registry) docker repositories in addition to the legacy GCR registries available for the same project, e.g.:Backwards Compatibility
Support for the legacy deprecated GCR registries is included in the GCP service connector. Users that already have GCP service connectors configured to access GCR registries will not be negatively impacted by this change.
Multi-type GCP Service Connector before the update:
Multi-type GCP Service Connector after the update:
Single-type GCP Service Connector before the update:
Single-type GCP Service Connector after the update:
For multi-type GCP Service Connectors, the ZenML server logs will report an error if the Google Artifact Registry permissions necessary to discover GAR registries are not yet configured for the GCP Service Connector credentials, but this does not prevent the GCP Service Connector from functioning with GCR registries, e.g.:
Users can follow the GCP guide on converting their existing GCR registries into Google Artifact Registries and follow them with the appropriate changes in their ZenML GCP Service Connectors:
artifactregistry.repositories.createOnPush
artifactregistry.repositories.downloadArtifacts
artifactregistry.repositories.get
artifactregistry.repositories.list
artifactregistry.repositories.readViaVirtualRepository
artifactregistry.repositories.uploadArtifacts
artifactregistry.locations.list
gcr.io
GCR URLs already configured in the GCP Service Connectors and in linked Container Registry stack components as long as these are redirected to GAR as covered in the transition GCR guide.Even if the GCP Service Connector credentials do not grant access to GCR registries, the GCP Service Connector will continue to report these legacy GCR registries as accessible. These will be removed in a future release.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes