Open avishniakov opened 2 weeks ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Describe changes
I fixed the max recursion issue with step-op controlled steps on the main process. Additionally, I simplified the merge function to avoid such issues in general. There is one BIG ASSUMPTION here: time on client and step op should be quite in sync, otherwise the order of the log might go crazy. Generally, this is not a super critical thing, since in the worst case it can plug all client logs to the end or to the beginning of the log file, so the major logs from step op will flow in chronological order.
@bcdurak this one also should solve the retry missing logs thingy.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes