Closed stefannica closed 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Now all Dockerized tests throw
TypeError: kwargs_from_env() got an unexpected keyword argument 'ssl_version'
and some templates died withModuleNotFoundError: No module named 'packaging'
I had to make more changes to remove our test environment dependency on the old and deprecated docker-compose
python package.
Now all Dockerized tests throw
TypeError: kwargs_from_env() got an unexpected keyword argument 'ssl_version'
and some templates died withModuleNotFoundError: No module named 'packaging'
I had to make more changes to remove our test environment dependency on the old and deprecated
docker-compose
python package.
That didn't work either due to some other docker-compose v2 dependencies. I chose to simply install an older version of docker whenever docker-compose is also required.
Now all Dockerized tests throw
TypeError: kwargs_from_env() got an unexpected keyword argument 'ssl_version'
and some templates died withModuleNotFoundError: No module named 'packaging'
I had to make more changes to remove our test environment dependency on the old and deprecated
docker-compose
python package.That didn't work either due to some other docker-compose v2 dependencies. I chose to simply install an older version of docker whenever docker-compose is also required.
How should the users proceed in this case? One needs docker-compose to run on cloud stacks, but the package requests a higher docker version. Wouldn't it give them problems?
Also there's a conflict to resolve
NLP template updates in examples/e2e_nlp
have been pushed.
Describe changes
Unpin
requests
and upgradedocker
to remediate: https://github.com/zenml-io/zenml/security/dependabot/279Related: https://github.com/zenml-io/zenml/pull/2716
The
docker-compose
package has been deprecated and no longer works with newer versions of thedocker
Python package. For that reason, we have to explicitly install an older version ofdocker
(and also an older version ofrequests
) whenever we need to usedocker-compose
in our CI.Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes