Closed wjayesh closed 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
In general I think ZenML should even be able to set those image pull secrets for users if they're using service connectors, correct?
@schustmi hundred percent. but this change should also include other orchestrators in general, eventually. Right now, service connectors are only useful client side. I can start with this one and we can deal with other orchestrators after this, what say?
In general I think ZenML should even be able to set those image pull secrets for users if they're using service connectors, correct?
This would be just a bit more difficult to set up, because you would have to give the ZenML pods permissions to create those secrets, but 100% that it should be doable.
Describe changes
I added image pull secrets to k8s pod settings to allow pods to pull images when they are running on private clusters and other environments where implicit access is not easy to provide.
An alternative to this would be to create a custom service account, attach pull secrets to it and then use it for your orchestrator and step pods but the more options, the merrier. This would also be easier to use, imo.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes