Closed strickvl closed 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@strickvl I think you can close it in favor of this PR I already had open: https://github.com/zenml-io/zenml/pull/2843
NLP template updates in examples/e2e_nlp
have been pushed.
I don't think removing the requests pin is enough to address the reason it was added there in the first place (https://github.com/docker/docker-py/issues/3256). Namely, this still fails for me:
pip install "docker==6.1.3"
python -c "from docker.client import DockerClient; DockerClient.from_env()"
but this works:
pip install "docker==6.1.3" "requests<2.32.0"
python -c "from docker.client import DockerClient; DockerClient.from_env()"
The only docker
version that works with requests
higher than 2.32.0 is docker==7.1.0
, but that has the unfortunate side-effect that it's no longer compatible with docker-compose, which we rely on to run our CI.
No longer needed since we have #2843
We pinned requests on account of this: https://github.com/docker/docker-py/issues/3256
New versions have been released which fix this, so I just remove the restriction on requests since it's such a fundamental library and it was blocking other dependency upgrades / usage.