Closed schustmi closed 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
NLP template updates in examples/e2e_nlp
have been pushed.
Describe changes
Our
ClientLazyLoader
class implements the__getattr__
method to allow accessing any non-existent attribute on it. This messed with the pythondict(...)
function that we used to convert a pydantic model to a dictionary in some RBAC utility functions. Thedict
function tries to first call thekeys()
method of an object to see if it is convertible to a dictionary in a certain way. This would fail with our lazy loaders as they returned a value whenlazy_loader.keys()
was called.I updated the RBAC utility functions to instead use
model.__iter__()
instead which avoids this issue.Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes