search

zenna / ParametricInversion.jl

MIT License
21 stars 2 forks source link

Mjolnir trace IR, Constants support, better type routing #9

Closed dmorejon closed 4 years ago

dmorejon commented 4 years ago

Use the Mjolnir package's trace function to get our forward IR and leverage its type inference and constant propagation.

Support inverting primitives that have a constant as an argument -> no dependence on a parameter.

Route the types of variables to better match the function method. For example: before we had invert + where output is a Float64.

Now, we say invert + where input is Float64, Int64.

Minor changes to primitives to reflect these changes.

Corresponding test for constants

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8b29a4d). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   55.86%           
=========================================
  Files             ?        7           
  Lines             ?      145           
  Branches          ?        0           
=========================================
  Hits              ?       81           
  Misses            ?       64           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b29a4d...761adb6. Read the comment docs.