search

zeno-ml / zeno-hub

AI Evaluation Platform
https://hub.zenoml.com
MIT License
44 stars 10 forks source link

fix: check element id with project before deleting element #527

Closed adityamittal13 closed 11 months ago

adityamittal13 commented 11 months ago

Description

fix ZEN-386

check files: chart.py, slice.py, tag.py, folder.py

linear[bot] commented 11 months ago

ZEN-386 should check that element that is being deleted actually belongs to the project we are checking access for

cabreraalex commented 11 months ago

you should be able to git merge origin/main to get rid of the extra changes

adityamittal13 commented 11 months ago

just made that change - check now

adityamittal13 commented 11 months ago

Just fixed the comment, check now.

adityamittal13 commented 11 months ago

Should be good now - had to change a couple of areas in the code that used the functions before, but ran locally and everything works.

cabreraalex commented 11 months ago

Fantastic, thanks so much! Will approve and merge once I fix the CI

cabreraalex commented 11 months ago

aha I can do that for this PR