search

zeno-ml / zeno-hub

AI Evaluation Platform
https://hub.zenoml.com
MIT License
44 stars 10 forks source link

fix: allow duplicate slice names #532

Open zaidsheikh opened 11 months ago

zaidsheikh commented 11 months ago

Description

Allow duplicate slice names, mainly so we can easily "Create slices for all values" without worrying about existing slice names. This was decided during a discussion on ZEN-282.

(Note: we probably need a way to disambiguate slices with the same name in the chart editor … maybe by including the folder name as well)

References

fix ZEN-399

(Note: this is a duplicate of my previous PR #531 which was created from a fork. CI tests kept failing because Github Action secrets are not accessible if the PR is from a fork)

linear[bot] commented 11 months ago

ZEN-399 Allow duplicate slice names

Sparkier commented 10 months ago

Hi @zaidsheikh is this ready for review?

zaidsheikh commented 10 months ago

I need to push one more commit to fix an issue with charts (they currently assume slice names are unique, so only one slice is shown even if multiple slices with the same name are selected).

Sparkier commented 10 months ago

Ah ok sounds good, thank you!