zeno-ml / zeno-hub

AI Evaluation Platform
https://hub.zenoml.com
MIT License
44 stars 10 forks source link

fix: gracefully fail charts if columns have changed #596

Closed Sparkier closed 10 months ago

Sparkier commented 10 months ago

Description

fix ZEN-414

This disentangles the fetching of chart data from the chart. The reason behind this is that fetching chart data has some failure cases (e.g. a column for a slice filter does not exist anymore) that should not break charts altogether. It should still be possible to change the chart spec. Furthermore, this adds an error message if the chart data could not be loaded.

linear[bot] commented 10 months ago

ZEN-414 gracefully fail charts if a column does not exist anymore

Sparkier commented 10 months ago

Our openapi codegen creates the function for fetching the data twice for some reason and I don't really understand why.

cabreraalex commented 10 months ago

yeah odd it did for me too