search

zenobht / zeno-theme

Other
18 stars 5 forks source link

Missing diff faces #1

Closed FelipeLema closed 2 years ago

FelipeLema commented 5 years ago

diff-refine-added, diff-refine-changed and diff-refine-removed.

To test them, open a diff file and navigate through it.

zenobht commented 5 years ago

Thanks for reporting. I will add them.

zenobht commented 5 years ago

@FelipeLema There was a release yesterday. Can you have a look and see if these faces are proper

FelipeLema commented 5 years ago

Here's a diff with refinement using default colors on 24bit-color terminal image

And here's the same diff with zeno-theme @ 0914c4a5b1b image

I can tell that it's making the refinement on both because when I run customize-face it offers diff-refine-added on the zeno word, although because the second one has the same face as diff-added it doesn't show.

You can try yourself with a diff file and doing M-x diff-refine-hunk with the cursor on either changed word.

Etenil commented 2 years ago

@FelipeLema I believed I fixed this one. Opened a PR.