search

zenogantner / MyMediaLite

recommender system library for the CLR (.NET)
http://mymedialite.net
502 stars 192 forks source link

Incremental support for ItemKNN and UserKNN item recommenders #377

Closed joaoms closed 11 years ago

joaoms commented 11 years ago

Hi,

I managed to add support for incremental updates to classic item recommenders (UserKNN and ItemKNN).

Class hierarchy changes:

Limitations:

Literature: http://www.springerlink.com/index/861k581047371165.pdf (no free pdf here...) https://www.forth.gr/ics/isl/publications/paperlink/LNCS_Formatted_ISMIS-05_34880553.pdf

Please send you comments. Regards, João Vinagre

zenogantner commented 11 years ago

Hi Joao,

thank you for the pull request. I haven't had the time yet to work on it, because I spent most of the holidays away from the computer.

I am also (still) learning git - it is powerful but complex system ;-)

One thing is a bit confusing to me - why are there different users that worked on the pull request? Could you simplify the commit history? That is (1) only commits by one user (if you were the only one committing ...) (2) logical steps towards the final (good) solution (3) no commits that add stuff which is later removed (then both steps can be omitted).

Here is a link that may help with (3): http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Otherwise, now that you know how the code should look in the end, it may be easier to start with the current master status, and perform a few clean commits. I know this may sound tedious, but it would make it easier for me (and people who will work on the repository at a later stage) to understand the changes.

In case you run into problems, or if there are any questions, don't hesitate to send me an e-mail.

Zeno

joaoms commented 11 years ago

Hi Zeno,

It's all me, sorry about the mess. I work on several workstations, and git configurations vary. Also, I'm using MML in my PhD work as I code, so there's too much unnecessary stuff going back and forth (sloppy debugging code, etc). I'm closing the request and I'll try to simplify this for the project's sake. Thanks for the squashing tip :)

João

zenogantner commented 11 years ago

Hi Joao,

no problem. Thank you for you patience!

Best regards, Z.

On Wed, Jan 9, 2013 at 5:21 PM, joaoms notifications@github.com wrote:

Hi Zeno,

It's all me, sorry about the mess. I work on several workstations, and git configurations vary. Also, I'm using MML in my PhD work as I code, so there's too much unnecessary stuff going back and forth (sloppy debugging code, etc). I'm closing the request and I'll try to simplify this for the project's sake. Thanks for the squashing tip :)

João

— Reply to this email directly or view it on GitHubhttps://github.com/zenogantner/MyMediaLite/pull/377#issuecomment-12051960.

MyMediaLite Recommender System Library: http://mymedialite.net