search

zenogantner / MyMediaLite

recommender system library for the CLR (.NET)
http://mymedialite.net
499 stars 192 forks source link

Issues for evaluation of unseen user and incremental modeling(AddFeedback) in BPRMF #426

Closed ummae closed 10 years ago

ummae commented 11 years ago
  1. Passing null parameter to HashSet when training_user_matrix[user_id] == null ===> ERROR: Argument cannot be null. Parameter name: collection at System.Collections.Generic.HashSet1[System.Int32]..ctor (IEnumerable1 collection, IEqualityComparer1 comparer) [0x0006d] in /data1/daum/kskim/program/mono-2.10.8/mcs/class/System.Core/System.Collections.Generic/HashSet.cs:123 at System.Collections.Generic.HashSet1[System.Int32]..ctor (IEnumerable`1 collection) [0x00000] in :0 at MyMediaLite.Eval.Items+cAnonStoreyA.<>m14 (Int32 user_id) [0x0002e] in /data1/daum/kskim/mymedialite.git/src/MyMediaLite/Eval/Items.cs:146
  2. To perform incremental modeling in BPRMF after LoadModel, random instance need to be initialized
zenogantner commented 10 years ago

Hi, thank you for the pull request. Your changes address 2 separate issues. Would it be possible to send it as 2 distinct pull requests, or at least as a pull request containing 2 distinct commits?

I could also commit this as is, but it is cleaner for the version history, and easier to test separately.

ummae commented 10 years ago

Hi, okay I will request this issues separately.

zenogantner commented 10 years ago

Tell me when I should have a look at it again.

ummae commented 10 years ago

Here, https://github.com/zenogantner/MyMediaLite/pull/427 , I request this two issues into two commits please check it.