zenogantner / MyMediaLite

recommender system library for the CLR (.NET)
http://mymedialite.net
499 stars 192 forks source link

two simple bugs #429

Closed guoguibing closed 10 years ago

guoguibing commented 10 years ago
  1. SparseMatrix.cs => line 161: index_list should be changed to value_list
  2. RatingData.cs => line 43, parameter ignore_first_line is missing.
zenogantner commented 10 years ago

Hi guoguibing, thank you for the bug reports. I have fixed them in the relevant branches. To make writing the doc/Changes file easier, you could report every bug in a single issue (nothing is too small for that ;-), but this way is also fine. Let me know your real name if you want to get credit in the README file.

Cheers, Z.

guoguibing commented 10 years ago

Hi Zeno,

Thanks for your reply. My name is Guibing Guo ( http://trust.sce.ntu.edu.sg/~gguo1/). I'm reading the source codes of MyMediaLite which are well written. I'll report new bugs if any.

Best Regards, Guibing Guo

On Mon, Jul 22, 2013 at 6:30 AM, Zeno Gantner notifications@github.comwrote:

Hi guoguibing, thank you for the bug reports. I have fixed them in the relevant branches. To make writing the doc/Changes file easier, you could report every bug in a single issue (nothing is too small for that ;-), but this way is also fine. Let me know your real name if you want to get credit in the README file.

Cheers, Z.

— Reply to this email directly or view it on GitHubhttps://github.com/zenogantner/MyMediaLite/issues/429#issuecomment-21318371 .

Best Regards, Guibing GUO