zenon-network / syrius

MIT License
17 stars 14 forks source link

Node connection established when canceling the Chain identifier mismatch dialog #81

Closed KingGorrin closed 3 months ago

KingGorrin commented 3 months ago

Describe the bug When connecting to a node that has a different chain ID than the one that is set for Syrius, a Chain identifier mismatch dialog is shown prompting the user to either Cancel or Proceed anyway. When pressing Cancel the connection to the new node is still established. The Node Management list then shows that Syrius is still connected to the previously selected node when it's not.

To Reproduce Precondition 1: you need access to two different nodes that are not the Embedded Node.

  1. Navigate to Settings > Node Management
  2. Make sure you're connected to a node that is not the Embedded Node
  3. Open Client chain identifier selection and set the identifier to a random number, like 999 for example.
  4. In Node selection connect to another node that is not the Embedded Node
  5. You should see the Chain identifier mismatch popup. Press Cancel.

Expected behavior The connection to the node is not established.

Actual behavior The connection to the node is established. On the UI this can be seen by the momentum height card updating.

Desktop

This issue was migrated from HyperCore-One and originally issued by @vilkris4 on May 7, 2023