search

zenon-network / syrius

MIT License
17 stars 14 forks source link

Plasma Generation Loop / Chain ID Mismatch #85

Closed coinselor closed 3 months ago

coinselor commented 3 months ago

Describe the bug After creating a new wallet, I requested funds from the testnet faucet and got stuck in a plasma generation loop. Auto-receiving was enabled. Funds are never received.

To Reproduce Steps to reproduce the behavior: Check description, and attached screenshots. I did check/uncheck auto-receive a couple of times and added the testnet faucet node during the Node Management window. No other special steps were taken.

Expected behavior I expect at most two `Plasma will be generated in order to receive transaction' notifications, one per pending transaction, and for transactions to eventually be received and shown in my balance. Additionally, if auto-receive is enabled, I expect the green down arrow buttons for manually receiving the transactions to not be shown or be grayed out.

I expect that during the Node Management window in the initial wallet creation flow, for the chain id warning to show up when adding a new node with a different chain id, as it happens when you do in the settings tab.

Workaround After trying to fuse some plasma from another wallet, I was getting Error while generating plasma. Turns out chain id is not automatically changed to '3' even though you get the notification when adding the node. I went back to check if this was the cause of the issue, and it was. After manually changing the chain id to '3', the account blocks were published after plasma generation and both transactions were successfully received.

Screenshots If applicable, add screenshots to help explain your problem. image

image Auto-received is enabled. These are unreceived transactions. Should these icons be shown/clickable at all? image

Desktop (please complete the following information):

Additional context

Should the client chain id be automatically set by syrius after the user clicks "proceed anyway" ?

KingGorrin commented 3 months ago

@coinselor please try out this build by downloading the binaries from the artifacts.

It should fix the notification problem and always show an error notification when failing to receive a tx.

coinselor commented 3 months ago

Works as expected.

image

Should I close the issue? Still learning the FOSS/GitHub etiquette ways...

KingGorrin commented 3 months ago

Great! I will close the issue when the PR is merged.