zenorocha / good-listener

A more versatile way of adding & removing event listeners
http://npmjs.com/good-listener
142 stars 29 forks source link

exports.function throws error in IE9 #4

Closed projectnard closed 8 years ago

projectnard commented 8 years ago

IE9 doesnt support named parameteres that are also keywords. So in src/is.js, line 45 throws and error.

exports.function = {}

zenorocha commented 8 years ago

Could you send a PR?

benjifs commented 8 years ago

I sent a pull request on behalf of bvferguson to fix this issue

zenorocha commented 8 years ago

Fixed in #5. Thanks for reporting @bvferguson!

Craga89 commented 8 years ago

As of 1.1.5 the dist files are now broken, due to the is module exporting function

https://github.com/zenorocha/good-listener/blob/v1.1.5/dist/good-listener.js#L144

But the main module is using is.fn:

https://github.com/zenorocha/good-listener/blob/v1.1.5/dist/good-listener.js#L172

benjifs commented 8 years ago

Just sent in a PR to address this issue