Open Quuxplusone opened 4 years ago
Orthogonal but minor: It would be nice to add a commit hook, or some check in makeh
, or something, that would fail the build whenever it saw #ifdef CAP_FOO
anywhere, or #ifndef CAP_FOO
outside of "sysconfig.h". The directives #if CAP_FOO
and #ifdef CAP_FOO
do different things when -DCAP_FOO=0
.
diff --git a/complex2.cpp b/complex2.cpp
index e861c827..11c490b2 100644
--- a/complex2.cpp
+++ b/complex2.cpp
@@ -8,7 +8,7 @@
*/
#include "hyper.h"
-#ifdef CAP_COMPLEX2
+#if CAP_COMPLEX2
namespace hr {
I just tried building with -DCAP_RUG=0
(failed) and with -DCAP_GL=0
and -DISMINI=1
(both failed with really confusing error messages). Some fruits of that labor are in #108.
@zenorogue : Have you seen the build failures in https://travis-ci.org/github/zenorogue/hyperrogue/jobs/687775577 ? They look like real issues to me.
This happens on Mac if you don't pass
HYPERROGUE_USE_PNG=1
. Because withoutCAP_PNG
, there's noCAP_TEXTURE
, and withoutCAP_TEXTURE
there's nonamespace texture
.The TravisCI matrix does not test
CAP_PNG=0
. I would be happy to submit a PR to add a coupleCAP_PNG=0
builds to the test matrix; alternatively, I would be happy to submit a PR to make-DCAP_PNG=1
mandatory and eliminate all the conditionals that depend on it.