search

zenorogue / hyperrogue

A SDL roguelike in a non-euclidean world
GNU General Public License v2.0
569 stars 72 forks source link

Android stability regression #311

Closed blargdag closed 2 years ago

blargdag commented 2 years ago

In the previous Android update (12.0b), when Hyperrogue is backgrounded it would add an "game in progress" notification to the system, which prevents Android from killing the game in progress. The latest update (12.0u) no longer has this, which means every time you switch away to from the app (e.g., incoming phone call, check notifications) there's a risk that the OS will just unceremoniously kill the current game. This effectively makes the game unplayable, because e.g., incoming phone calls are not under the user's control, but can randomly kill hours of gameplay forcing you to restart from zero.

Please reinstate the in-progress notification, as otherwise the game is basically unplayable on Android.

zenorogue commented 2 years ago

Seems to work for me. This feature is enabled only if you have >= 10 treasure or >= 50 kills, maybe you are testing in a very early game?

blargdag commented 2 years ago

On Sat, Jul 16, 2022 at 02:15:18AM -0700, Zeno Rogue wrote:

Seems to work for me. This feature is enabled only if you have >= 10 treasure or >= 50 kills, maybe you are testing in a very early game? [...]

Tested again, it seems the problem is actually caused by hyperrogue crashing upon switching away, and sometimes when dying. Do you know if there's some way of getting at the error message? I don't see anything obvious but at least once the OS prompted me to clear the cache because the app keeps crashing, so there's definitely something going on.

This is definite happening with >=10 treasure.

zenorogue commented 2 years ago

Thanks for the report!! Again, some changes to Android have made HyperRogue crash... hopefully should be fixed in 12.0v.

zenorogue commented 2 years ago

@blargdag could you please confirm if it works now?

blargdag commented 2 years ago

Checked Google Play Store, apparently it hasn't published the update yet. Is there another source I can get the apk from?

zenorogue commented 2 years ago

Seems HyperRogue Gold 12.0v was not uploaded for some reason (but standard HyperRogue 12.0v should be there).

I have also uploaded 12.0v to https://zenorogue.itch.io/hyperrogue

blargdag commented 2 years ago

Looks like 12.0v Gold just hit Play Store. Seems to work now, thanks!!