search

zenorogue / hyperrogue

A SDL roguelike in a non-euclidean world
GNU General Public License v2.0
569 stars 72 forks source link

OSM: Make the orb quantity in the inventory screen black. #327

Closed jlmjlm closed 1 year ago

jlmjlm commented 1 year ago

An unintended side effect of the orb icons I created was to reduce the legibility of the orb quantities in OSM, because they also operate by darkening a shape (in this case, a numeral instead of an icon) on the orb's disk.

This aims to fix that problem I introduced by making the number overlay black, which should be a good contrast with any orb.

Before: osm_before

After: osm_after

Quuxplusone commented 1 year ago

I wonder: I've never looked at the graphics-display code, but is it possible to do "black text with a white outline" (or vice versa), and if so, maybe do that and even move the number to the lower right corner of the orb so it doesn't overlay the identifying icon in the middle of the orb? Or is that basically asking for the impossible? :)

jlmjlm commented 1 year ago

Please feel free to make alternative or conflicting PR's, or use this one as a base to modify, if you think yours will look better. It's entirely possible I'll agree!

zenorogue commented 1 year ago

It is of course possible to make black text with a white outline, but HyperRogue has "default dialog text color" and "default boundary color" settings, and there is no good reason to ignore these settings in this context.

The idea to move the number to the lower right corner is great though.

So now it uses the old style if the orb mode is not "icons", and a default-dialog-colored number in bottom right if the orb mode is "icons".

The changes are already pushed. Thanks for the ideas!

jlmjlm commented 1 year ago

I just did an OSM run, and I like the look of what you did instead, Zeno. Thanks!