zenorogue / hyperrogue

A SDL roguelike in a non-euclidean world
GNU General Public License v2.0
554 stars 66 forks source link

Build regression in 13.0r #380

Open AMDmi3 opened 3 weeks ago

AMDmi3 commented 3 weeks ago
In file included from hyper.cpp:89:
./mapeditor.cpp:2241:10: warning: unused variable 'freedraw' [-Wunused-variable]
    bool freedraw = drawing_tool || intexture;    
         ^
./mapeditor.cpp:2390:46: error: use of undeclared identifier 'texture'
      dialog::addBoolItem_action("symmetry", texture::texturesym, '0');
                                             ^
./mapeditor.cpp:2416:21: error: use of undeclared identifier 'texture'
      int s = isize(texture::config.data.pixels_to_draw);
                    ^
./mapeditor.cpp:2970:11: warning: unused variable 'tcolor' [-Wunused-variable]
      int tcolor = (dtcolor >> 8) | ((dtcolor & 0xFF) << 24);
          ^
zenorogue commented 2 weeks ago

Compilation with texture mode disabled did not work correctly. This should be fixed in 13.0s.

(Why compile with texture mode disabled? Better to enable it, unless you do not want the dependency on libpng)

AMDmi3 commented 2 weeks ago

Why compile with texture mode disabled?

No idea, I though my package is built with more or less default flags. Which flag controls this?

AMDmi3 commented 2 weeks ago

Found it. Probably was lost after autotools elimination. The need to enable it explicitly is quite strange, maybe enable it by default instead?