Add default "capacity_get_threshold_configs" method to ZenPack.py

zenoss / ZenPacks.zenoss.ZenPackLib

This is a helper library for zenpacks.

http://zenpacklib.zenoss.com/

GNU General Public License v2.0

15 stars 17 forks source link

Add default "capacity_get_threshold_configs" method to ZenPack.py #503

Closed j053ph4 closed 6 years ago

j053ph4 commented 6 years ago

This should facilitate automatic generation of Capacity ZP thresholds for the case when Capacity ZP is installed after a given ZP with Capacity thresholds defined.

j053ph4 commented 6 years ago

I added documentation and tests, and also updated this fix to automatically handle both installed and not installed scenarios automatically (meaning that the capacity thresholds can now be included in the YAML file without the earlier workaround)

j053ph4 commented 6 years ago

Trotting out the slippery slope argument here...why stop at thresholds then? Why not deal with missing datasource or datapoint or graphpoint classes as well? Would that then obligate us to come up with various workarounds for non-sequential installation/dependency satisfaction?

j053ph4 commented 6 years ago

Also I wanted to point out that the "optional" flag for thresholds exists for ThresholdSpec as well