zenoss / ZenPacks.zenoss.ZenPackLib

This is a helper library for zenpacks.
http://zenpacklib.zenoss.com/
GNU General Public License v2.0
15 stars 17 forks source link

Ensure that zenpacklib exports YAML as expected (ZPS-1746) #511

Closed j053ph4 closed 6 years ago

j053ph4 commented 6 years ago
cluther commented 6 years ago

I’m not sure why ZPS-1746 is even a problem. I thought we had decided that objects added by zenpacklib from YAML wouldn’t be exported. The only process classes that should be exported by zenpacklib --dump-process-classes are those that were loaded from XML, or created by the user and associated with a ZenPack.

This is related to ZPS-1601, and subsequent ZPS-2660 that had to fix the regression its fix caused.

There’s no need to export YAML for something when you can just find the YAML in the source file already.

I think the test case for ZPS-1746 is wrong. We should be testing by manually creating the process class through the UI, adding it to the ZenPack, then using zenpacklib --dump-process-classes to see if it dumps to YAML.