search

zenoss / ZenPacks.zenoss.ZenPackLib

This is a helper library for zenpacks.
http://zenpacklib.zenoss.com/
GNU General Public License v2.0
15 stars 17 forks source link

Improve ZPL efficiency during loading yamls #572

Closed StevePC closed 9 months ago

StevePC commented 9 months ago

Stop ZPL load_yaml from reading and parsing all the yaml files only to re-export them as yaml text and re-load it all again. Stop wasting time and memory making a new LogAdapter class for each Spec instance.

odubrovyk commented 9 months ago

@StevePC I wanted to install the feature build and run unit tests but got a lot of tracebacks during the upgrade:

ERROR:Application:Could not import Products.ZenossStartup
and
AttributeError: 'NoneType' object has no attribute 'zenpack_module'
and other errors

You can review the full tracebacks by performing the ZenPackLib upgrade on your dev instance. Could you please check the ZenPackLib installation and unittests?

Besides this, I got the following traceback for the migration:

2024-01-05 15:40:35,456 ERROR zen.ZenPackCmd: zenpack command failed
Traceback (most recent call last):
  File "/opt/zenoss/Products/ZenUtils/zenpack.py", line 934, in <module>
    zp.run()
  File "/opt/zenoss/Products/ZenUtils/zenpack.py", line 258, in run
    ignoreServiceInstall=self.options.ignoreServiceInstall)
  File "/mnt/src/zenoss-prodbin/Products/ZenUtils/ZenPackCmd.py", line 273, in InstallEggAndZenPack
    raise e
  File "/mnt/src/ZenPacks.zenoss.ZenPackLib/ZenPacks/zenoss/ZenPackLib/migrate/FixReplacementTemplates.py", line 34
    if availtempls = None:
                   ^
SyntaxError: invalid syntax

There is a syntax error in the migration file that we did not notice.

odubrovyk commented 9 months ago

Also, could you please change the summary and write the description in the very verst comment? Describe all of your changes in the description, please.