search

zenovich / runkit

Runkit (official PECL PHP Runkit extension)
http://pecl.php.net/runkit
Other
611 stars 136 forks source link

Fixed compiling against PHP 5.6.0RC4 #71

Closed adrolter closed 9 years ago

adrolter commented 10 years ago

Fixes #69

tototoshi commented 10 years ago

+1

bantu commented 10 years ago

@adrianguenter Your master branch seems to be this master branch + this fix (according to https://github.com/zenovich/runkit/network). I used your master branch in https://travis-ci.org/phpseclib/phpseclib/builds/34353381 and it seems to work on 5.6 now, but seems to have broken < 5.6.

tony2001 commented 10 years ago

Right, the patch fixes 5.6, but breaks older versions. It should have contained something like this:

#ifndef IS_CONSTANT_AST
# define IS_CONSTANT_AST IS_CONSTANT_ARRAY
#endif
82rules commented 9 years ago

:+1: on 5.6 support but I agree the change should be backwards compatible.

denji commented 9 years ago

@zenovich The last release was in 2010' year, can raise the crane version?

davidcasey commented 9 years ago

+1

Qix- commented 9 years ago

Yeah this needs to get added :P Can we please push this forward?

rotatingJazz commented 9 years ago

+1000 :+1:

davidsteinsland commented 9 years ago

As there were some merge conflicts and BC related stuff here, I created #73 instead.

zenovich commented 9 years ago

Done in #73