Fixed compilation with PHP 5.6

zenovich / runkit

Runkit (official PECL PHP Runkit extension)

http://pecl.php.net/runkit

Other

611 stars 136 forks source link

Fixed compilation with PHP 5.6 #73

Closed davidsteinsland closed 9 years ago

davidsteinsland commented 9 years ago

Tested against PHP 5.6.3 and 5.5.20.

Qix- commented 9 years ago

Yes please :D

tototoshi commented 9 years ago

:+1:

Qix- commented 9 years ago

Where are the maintainers to review this? I have clients that need to install Runkit and I don't feel comfortable telling them they need to use a patch from a non-official account... This should be a no brainer.

tmuras commented 9 years ago

@Qix- I'd suggest to contact @zenovich directly and offer to pay him for that review and merge.

Qix- commented 9 years ago

@tmuras Thanks for the snarky and useless comment :+1:

nijel commented 9 years ago

Any plans to add PHP 7 support as well?

tony2001 commented 9 years ago

I seriously doubt all this stuff is going to work with PHP7. Most likely it'll require some serious modifications.